Add ID index functionality for efficient feature lookup by OSM ID#35
Open
JeremyBYU wants to merge 1 commit intoclarisma:mainfrom
Open
Add ID index functionality for efficient feature lookup by OSM ID#35JeremyBYU wants to merge 1 commit intoclarisma:mainfrom
JeremyBYU wants to merge 1 commit intoclarisma:mainfrom
Conversation
This was referenced Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Work
Adds efficient feature lookup by OSM ID using pre-built index files (
*-indexes/directory generated bygeodesk-gol). Avoids full tile scans by narrowing search to the specific tile containing the feature.What Changed
IdIndexclass (src/feature/IdIndex.cpp,include/geodesk/feature/IdIndex.h) - Loads and queries index files, maps pile numbers to tile pointers, scans R-tree for matching IDsFeaturesBase- AddedbyId(id)method:nodes.byId(123),ways.byId(456),relations.byId(789)IdIndexon first useexamples/query-id/)clarisma/store/IndexFile.cppAmount of Risk
Targeted change, low risk.
byId()returns nullIdIndexclassFuture Work
w[id=12345]or/w12345or a dedicatedbyId()function. Wanted to get your opinion on best way to handle that.